Skip to content

Add seperator in high contrast mode #34546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Oct 13, 2022
Merged

Add seperator in high contrast mode #34546

skjnldsv merged 1 commit into from
Oct 13, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Oct 11, 2022 •
edited
Loading

Between navigation and content and between entry in breadcrump

image

@CarlSchwan
Add seperator in high contrast mode
8a8f150 
Between navigation and content and between entry in breadcrump

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews accessibility labels Oct 11, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Oct 11, 2022
@CarlSchwan CarlSchwan requested a review from a team October 11, 2022 21:46
@CarlSchwan CarlSchwan self-assigned this Oct 11, 2022
@CarlSchwan CarlSchwan requested review from PVince81, artonge and skjnldsv and removed request for a team October 11, 2022 21:46
szaimen
szaimen approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but didnt test

skjnldsv
skjnldsv requested changes Oct 12, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To specific imho, this is not the place to add such rules 🤔

@CarlSchwan
Copy link
Member Author

CarlSchwan commented Oct 12, 2022

To specific imho, this is not the place to add such rules thinking

what is the place then? There is unfortunately no easy way to add css code that will only be used when a theme is used :(

@skjnldsv
Copy link
Member

skjnldsv commented Oct 13, 2022

what is the place then? There is unfortunately no easy way to add css code that will only be used when a theme is used :(

Fair enough, I'll optimize this for 26 :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 13, 2022
@skjnldsv skjnldsv merged commit 9d0f529 into master Oct 13, 2022
@skjnldsv skjnldsv deleted the improve-hight-contrast branch October 13, 2022 10:17
@Pytal Pytal mentioned this pull request Nov 18, 2022
Merged
@Pytal
Copy link
Member

Pytal commented Nov 18, 2022

stable25 backport #34546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

+1 more reviewer

@YasinAshorian YasinAshorian YasinAshorian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CarlSchwan CarlSchwan

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

7 participants

@CarlSchwan @skjnldsv @Pytal @artonge @szaimen @YasinAshorian