Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 12, 2022

the previously called endpoint returns exactly one value, no JSON structure

fixes #34201, introduced in #33947

@blizzz blizzz added this to the Nextcloud 26 milestone Oct 12, 2022
@blizzz blizzz requested review from a team, CarlSchwan, come-nc and juliusknorr and removed request for a team October 12, 2022 12:54
@blizzz
Copy link
Member Author

blizzz commented Oct 12, 2022

/backport to stable25

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 wow

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2022
@blizzz blizzz added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 12, 2022
@blizzz

This comment was marked as resolved.

@blizzz blizzz force-pushed the fix/34201/broken-web-updater branch from 6c9e649 to f3792b6 Compare October 12, 2022 13:29
the previously called endpoint returns exactly one value, no JSON
structure

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz force-pushed the fix/34201/broken-web-updater branch from f3792b6 to 52c1dbf Compare October 12, 2022 13:30
@blizzz
Copy link
Member Author

blizzz commented Oct 12, 2022

In Vue/axios-land the data in .then(({ data }) => { is magic and must not be renamed?!

@PVince81
Copy link
Member

In Vue/axios-land the data in .then(({ data }) => { is magic and must not be renamed?!

if I understand correctly, the Promise function will be called with an object that looks like { data: { something: ... }, status: ..., ...} and with this shortcut syntax you tell Javascript that you are only interested in the "data" key

otherwise you need to change it to then(response) and then check response.data

@blizzz blizzz merged commit 4c64a60 into master Oct 12, 2022
@blizzz blizzz deleted the fix/34201/broken-web-updater branch October 12, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NC 25 error when trying upgrade from beta 7 to RC1 with GUI

4 participants