Require token for local editing #34559
Conversation
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
changed the title
|
/backport to stable25 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $pathHash = sha1($path); | ||
|
|
||
| $entity = new OpenLocalEditor(); | ||
| $entity->setUserId($this->userId); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| $pathHash = sha1($path); | ||
|
|
||
| try { | ||
| $entity = $this->mapper->verifyToken($this->userId, $pathHash, $token); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| */ | ||
| class OpenLocalEditor extends Entity { | ||
| /** @var string */ | ||
| protected $userId; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| protected $userId; | ||
|
|
||
| /** @var string */ | ||
| protected $pathHash; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| protected $pathHash; | ||
|
|
||
| /** @var int */ | ||
| protected $expirationTime; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| protected $expirationTime; | ||
|
|
||
| /** @var string */ | ||
| protected $token; |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor
| * @throws MultipleObjectsReturnedException | ||
| * @throws Exception | ||
| */ | ||
| public function verifyToken(string $userId, string $pathHash, string $token): OpenLocalEditor { |
Check notice
Code scanning / Psalm
MoreSpecificReturnType
| ->andWhere($qb->expr()->eq('path_hash', $qb->createNamedParameter($pathHash))) | ||
| ->andWhere($qb->expr()->eq('token', $qb->createNamedParameter($token))); | ||
|
|
||
| return $this->findEntity($qb); |
Check notice
Code scanning / Psalm
LessSpecificReturnStatement
No description provided.