Filter out backup user status (those beginning with _ as userId) #34569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Oct 13, 2022
Member
|
/backport to stable25 |
CarlSchwan
approved these changes
Oct 13, 2022
CarlSchwan
requested changes
Oct 13, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Actually doing that on the db status is a better idea. Can i push yo your branch?
Member
Author
Sure! I just was not able to do it, knowledge wise. |
YasinAshorian
approved these changes
Oct 13, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
@CarlSchwan I hope you don't mind me pushing here. I just fixed your typo leading to a syntax error. |
julien-nc
approved these changes
Oct 13, 2022
Member
Author
|
Signed-off-by: Carl Schwan <[email protected]>
PVince81
reviewed
Oct 13, 2022
CarlSchwan
force-pushed
the
filterOutBackupStatus
branch
from
d3998b6 to
8c95e46
Compare
PVince81
added
4. to release
nickvergessen
requested changes
Oct 13, 2022
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Carl Schwan <[email protected]>
Member
Author
|
This works now! Thanks Joas! |
nickvergessen
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34464
Maybe it is smarter to do it directly on DB level, but I failed to do so…