[stable25] Fix missing background on upgrade #34587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
...and execute delete query Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
- fallback to background image from old location - migrate background images to new location as insensitive job Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
blizzz
requested review from
ArtificialOwl,
PVince81,
Pytal,
come-nc and
nickvergessen
skjnldsv
approved these changes
Oct 13, 2022
Member
|
I've tested this on master: #34461 (comment) |
PVince81
added
4. to release
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $this->jobList = $jobList; | ||
| } | ||
|
|
||
| protected function run($argument): void { |
Check notice
Code scanning / Psalm
MissingParamType
| return 'Initialize migration of background images from dashboard to theming app'; | ||
| } | ||
|
|
||
| public function run(IOutput $output) { |
Check notice
Code scanning / Psalm
MissingReturnType
Pytal
approved these changes
Oct 13, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #34461
I didn't take over the version bump in version.php as it comes with RC4 already anyway.