Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #34626

@backportbot-nextcloud backportbot-nextcloud bot added the pending documentation This pull request needs an associated documentation update label Oct 24, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 23.0.11 milestone Oct 24, 2022
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34626 (comment) this change is potentially breaking

@skjnldsv skjnldsv mentioned this pull request Oct 27, 2022
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
@blizzz blizzz mentioned this pull request Nov 21, 2022
8 tasks
@blizzz
Copy link
Member

blizzz commented Nov 23, 2022

Then let's not do it for 23 at all, k?

@blizzz blizzz mentioned this pull request Nov 29, 2022
8 tasks
@ChristophWurst
Copy link
Member

@AndyScherzinger I would vote against backporting the code identifier changes as they could break any apps that show a setting section on the groupware page.

If renaming is important for older releases we could only touch the UI string and leave the internal identifier. That means app sections can still be rendered. In the worst case they show on a page that semantically doesn't fit their purpose because groupware no longer shows Groupware settings but Availability settings.

It's the lesser of the two evils though :)

@AndyScherzinger
Copy link
Member

for older releases we could only touch the UI string and leave the internal identifier

fine by me as a solution @ChristophWurst

@blizzz blizzz mentioned this pull request Dec 8, 2022
@blizzz blizzz removed this from the Nextcloud 23.0.12 milestone Dec 8, 2022
@PVince81
Copy link
Member

23 is EOL

@PVince81 PVince81 closed this Dec 16, 2022
@ChristophWurst ChristophWurst deleted the backport/34626/stable23 branch December 16, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants