-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix overflow in Nextcloud Files meat ball menus (grid) #34826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would prefer to break-word :) |
OK @skjnldsv I think you are right, and I didn't think about this solution. I'll make the necessary changes in a new commit. |
|
@skjnldsv, however, I found a problem with the OpenProject button that should not be implemented like the others (it may not respect a certain integration standard). |
|
@skjnldsv I took advantage of this graphic modification to make the button take up the whole width, which can be seen when you move the cursor over it. |
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Jérôme Herbinet [email protected] Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]> Thanks @skjnldsv for the suggestion.
This reverts commit eed5edd. Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
29f3988 to
90edffb
Compare
|
Please help me, I have troubles with some commits that don't belong to me. Thanks by advance. |
hm... maybe it is easier to create a new branch and PR with your changes? |


Signed-off-by: Jérôme Herbinet [email protected]
Signed-off-by: Jérôme Herbinet [email protected]
Here is a fix for an overflow in the meat balls menus in the NC Files in grid view.
No problem here in English but, there is a problem in other languages like German and French which use longer wordings.
In Nextcloud 24, there was an ellipsis (difficult to read and guess hidden words). In Nextcloud 25 (ugly), there is no more ellipsis, and we have an overflow instead.
I propose to enlarge the box to guaranty real wordings' visibility in most languages. What do you think ?
Before :

After :

When I talked about visibility in Nextcloud 24, here is an example :
