Skip to content

Conversation

@Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Oct 26, 2022

Signed-off-by: Jérôme Herbinet [email protected]

Signed-off-by: Jérôme Herbinet [email protected]

Here is a fix for an overflow in the meat balls menus in the NC Files in grid view.
No problem here in English but, there is a problem in other languages like German and French which use longer wordings.
In Nextcloud 24, there was an ellipsis (difficult to read and guess hidden words). In Nextcloud 25 (ugly), there is no more ellipsis, and we have an overflow instead.
I propose to enlarge the box to guaranty real wordings' visibility in most languages. What do you think ?

Before :
2022-10-26_16-14

After :
2022-10-26_16-13

When I talked about visibility in Nextcloud 24, here is an example :
2022-10-26_16-29

@Jerome-Herbinet Jerome-Herbinet changed the title Fix overflow in Nextcloud Files meat ball menus (grid) Nextcloud 25 : Fix overflow in Nextcloud Files meat ball menus (grid) Oct 26, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 27, 2022
@szaimen szaimen added the 3. to review Waiting for reviews label Oct 27, 2022
@skjnldsv skjnldsv changed the title Nextcloud 25 : Fix overflow in Nextcloud Files meat ball menus (grid) Fix overflow in Nextcloud Files meat ball menus (grid) Oct 27, 2022
@skjnldsv
Copy link
Member

I would prefer to break-word :)

@Jerome-Herbinet
Copy link
Member Author

I would prefer to break-word :)

OK @skjnldsv I think you are right, and I didn't think about this solution. I'll make the necessary changes in a new commit.
We keep in touch.

@Jerome-Herbinet
Copy link
Member Author

@skjnldsv :

Before :
Capture d’écran de 2022-10-28 14-09-33

After :
Capture d’écran de 2022-10-28 14-09-40

@Jerome-Herbinet
Copy link
Member Author

@skjnldsv, however, I found a problem with the OpenProject button that should not be implemented like the others (it may not respect a certain integration standard).

@Jerome-Herbinet
Copy link
Member Author

@skjnldsv I took advantage of this graphic modification to make the button take up the whole width, which can be seen when you move the cursor over it.

@Jerome-Herbinet
Copy link
Member Author

@szaimen I invite you to check the last changes (following @skjnldsv suggestion) which replace what I did first.
If everything is OK and approved, I suggest to backport this to Nextcloud 25 (this would be nice). Thanks.

artonge and others added 6 commits October 28, 2022 15:19
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Jérôme Herbinet [email protected]

Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>

Thanks @skjnldsv for the suggestion.
This reverts commit eed5edd.

Signed-off-by: Jérôme Herbinet <[email protected]>
Signed-off-by: Jérôme Herbinet <[email protected]>
@Jerome-Herbinet
Copy link
Member Author

Please help me, I have troubles with some commits that don't belong to me. Thanks by advance.

@szaimen
Copy link
Contributor

szaimen commented Oct 30, 2022

Please help me, I have troubles with some commits that don't belong to me. Thanks by advance.

hm... maybe it is easier to create a new branch and PR with your changes?

@Jerome-Herbinet
Copy link
Member Author

@szaimen
I close this PR and have created a new one : #34891

@szaimen szaimen removed this from the Nextcloud 26 milestone Oct 31, 2022
@Jerome-Herbinet Jerome-Herbinet deleted the patch-9 branch August 31, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants