Skip to content

Reduce number of queries to read shares in a folder #34918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starypatyk wants to merge 8 commits into from
Closed

Reduce number of queries to read shares in a folder #34918

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
10bc136
Reduce number of queries to read shares
starypatyk Nov 1, 2022
1d3070b
An attempt to fix testGetShares unit test
starypatyk Nov 1, 2022
641968d
Experimental change - disable uid check
starypatyk Nov 3, 2022
7d57fbf
Fixes after review
starypatyk Nov 6, 2022
0aca9f1
Seems to run as expected with uid check disabled
starypatyk Nov 6, 2022
093e47e
Additional fixes after review (removed references)
starypatyk Nov 7, 2022
6054d48
Revert: Experimental change - disable uid check
starypatyk May 2, 2023
c7f5d11
Revert "Revert: Experimental change - disable uid check"
starypatyk Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert: Experimental change - disable uid check 
Signed-off-by: Dariusz Olszewski <[email protected]>
  • Loading branch information
@starypatyk @AndyScherzinger
starypatyk authored and AndyScherzinger committed Feb 27, 2024
commit 6054d48bbfacc64e424cbf87779da7d320328600
7 changes: 7 additions & 0 deletions lib/private/Share20/DefaultShareProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,13 @@ public function getSharesInFolder($userId, Folder $node, $reshares, $shallow = t
*/
if ($reshares === false) {
$qb->andWhere($qb->expr()->eq('uid_initiator', $qb->createNamedParameter($userId)));
} else {
$qb->andWhere(
$qb->expr()->orX(
$qb->expr()->eq('uid_owner', $qb->createNamedParameter($userId)),
$qb->expr()->eq('uid_initiator', $qb->createNamedParameter($userId))
)
);
}

// todo? maybe get these from the oc_mounts table
Expand Down