Skip to content

Avoid a crash when a PHP extension has no version #34937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 2 commits into from
Nov 7, 2022
Merged

Avoid a crash when a PHP extension has no version #34937

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56f24cf
Avoid a crash when a PHP extension has no version
come-nc Nov 3, 2022
7af4fea
Suppress false-positives from psalm, waiting for fix upstream
come-nc Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Suppress false-positives from psalm, waiting for fix upstream 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Nov 7, 2022
commit 7af4fea0e3a41f160b83bd48ae16c31b651f9cf1
4 changes: 4 additions & 0 deletions lib/private/App/PlatformRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ protected function initialize(): array {
$ext = new \ReflectionExtension($name);
try {
$prettyVersion = $ext->getVersion();
/** @psalm-suppress TypeDoesNotContainNull
* @psalm-suppress RedundantCondition
* TODO Remove these annotations once psalm fixes the method signature ( https://github.com/vimeo/psalm/pull/8655 )
*/
$prettyVersion = $this->normalizeVersion($prettyVersion ?? '0');
} catch (\UnexpectedValueException $e) {
$prettyVersion = '0';
Expand Down