Skip to content

Drop PHP 7.4 on master #34997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 24 commits into from
Jan 20, 2023
Merged

Drop PHP 7.4 on master #34997

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9369b67
Drop PHP 7.4 support for master (26)
come-nc Nov 7, 2022
7ebbb6b
Remove workarounds specific to 7.4
come-nc Nov 7, 2022
53cdd1e
Attempt at bumping psalm version
come-nc Nov 7, 2022
f27c3d0
composer update php
come-nc Nov 7, 2022
a1af357
Move all drone steps to PHP 8.0
come-nc Nov 7, 2022
87ebf28
Fix kerberos step name
come-nc Nov 7, 2022
e91457d
Improve typing in Entity.php
come-nc Nov 7, 2022
0c466b7
Attempt at reducing psalm errors
come-nc Dec 13, 2022
f2cdc4f
Fix crash in OCS when getting info about an application
come-nc Dec 13, 2022
2a5e18b
Fix types in OCS json answer (status code is an int)
come-nc Dec 19, 2022
90b955b
Attempt to fix errors in Repair command tests
come-nc Dec 19, 2022
e8299d4
Merge back the two static analysis workflows together
come-nc Jan 2, 2023
f6ed727
Always upload psalm result to github
come-nc Jan 2, 2023
9acb982
Prettify static-code-analysis.yml
come-nc Jan 3, 2023
b22b643
Fix gzip mimetype mapping
come-nc Jan 3, 2023
de68fc6
Update test file for mimetypes
come-nc Jan 3, 2023
89dbc62
Fix integrity check
nickvergessen Jan 4, 2023
7e0a024
Remove PHP version matrix from kerberos test
come-nc Jan 5, 2023
f8d222d
Fix Samba test failure details output
come-nc Jan 10, 2023
7b93a14
Fix check in integration tests
come-nc Jan 12, 2023
55baa7b
Fixing samba test and adding details to kerberos job
come-nc Jan 12, 2023
83d2655
Show failure of SAML login in kerberos workflow
come-nc Jan 12, 2023
d2204a7
Always show the psalm baseline change, even on failure
come-nc Jan 16, 2023
f32d18d
Bump 3rdparty to master branch
come-nc Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix check in integration tests 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Jan 20, 2023
commit 7b93a143c827ae64393865cbafb455cd38745f58
2 changes: 1 addition & 1 deletion build/integration/features/bootstrap/Sharing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ private function assertFieldIsInReturnedShare(string $field, string $contentExpe
return;
}

if (!array_key_exists($field, $returnedShare)) {
if (!property_exists($returnedShare, $field)) {
Assert::fail("$field was not found in response");
}

Expand Down