Skip to content

[stable23] Avoid a crash when a PHP extension has no version #34999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 2 commits into from
Nov 8, 2022
Merged

[stable23] Avoid a crash when a PHP extension has no version #34999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0bc2b
Avoid a crash when a PHP extension has no version
come-nc Nov 3, 2022
ec6ed96
Suppress false-positives from psalm, waiting for fix upstream
come-nc Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Avoid a crash when a PHP extension has no version 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot-nextcloud
come-nc authored and backportbot-nextcloud[bot] committed Nov 7, 2022
commit 2b0bc2bb2cdd3d7267cb8a60df7a689b75180a28
5 changes: 4 additions & 1 deletion lib/private/App/PlatformRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ protected function initialize() {
$ext = new \ReflectionExtension($name);
try {
$prettyVersion = $ext->getVersion();
$prettyVersion = $this->normalizeVersion($prettyVersion);
$prettyVersion = $this->normalizeVersion($prettyVersion ?? '0');
} catch (\UnexpectedValueException $e) {
$prettyVersion = '0';
$prettyVersion = $this->normalizeVersion($prettyVersion);
Expand Down Expand Up @@ -109,6 +109,9 @@ protected function initialize() {
continue 2;
}

if ($prettyVersion === null) {
continue;
}
try {
$prettyVersion = $this->normalizeVersion($prettyVersion);
} catch (\UnexpectedValueException $e) {
Expand Down