fix check if the certificate bundle needs to be updated #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiessle, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @LukasReschke and @DeepDiver1975 to be potential reviewers |
Member
|
I dont think it's correct since it now checks the mtime of the bundle it's going to write |
… specific certificate bundle if a user is given
schiessle
force-pushed
the
fix-check-certificate-bundles
branch
from
c493791 to
49cad15
Compare
Member
Author
ok, I see your point. I updated the PR, now it should be correct. |
Member
|
👍 |
Member
|
Makes sense 👍 |
Member
|
Ops, didnt see the open unit test task |
Member
Author
|
@nickvergessen no problem... will add them in a second PR |
This was referenced Sep 5, 2021
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…cloud#350) Fix incorrect info logging, log after imageId change Signed-off-by: Andrey Borysenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always check the mtime of the system bundle and additionally the user specific certificate bundle if a user is given.
I think this is how the function should look like, @icewind1991 and @LukasReschke please have a look. Thanks!