Skip to content

[stable24] invalidate existing tokens when deleting an oauth client #35094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 6 commits into from
Jan 6, 2023
Merged

[stable24] invalidate existing tokens when deleting an oauth client #35094

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a33c71
invalidate existing tokens when deleting an oauth client
individual-it Nov 11, 2022
0570327
public interface to invalidate tokens of user
individual-it Nov 21, 2022
7f3badd
adjust SettingsController tests
individual-it Nov 22, 2022
bcfd571
unit tests for Manager::invalidateTokensOfUser
individual-it Nov 22, 2022
a0788a8
added @since tag
individual-it Nov 22, 2022
c001c4b
autoloaderchecker
individual-it Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unit tests for Manager::invalidateTokensOfUser 
Signed-off-by: Artur Neumann <[email protected]>
  • Loading branch information
@individual-it @PVince81
individual-it authored and PVince81 committed Dec 20, 2022
commit bcfd571d83396f926dad8970d83f64377b3f75e3
44 changes: 44 additions & 0 deletions tests/lib/Authentication/Token/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,4 +355,48 @@ public function testUpdatePasswords() {

$this->manager->updatePasswords('uid', 'pass');
}

public function testInvalidateTokensOfUserNoClientName() {
$t1 = new PublicKeyToken();
$t2 = new PublicKeyToken();
$t1->setId(123);
$t2->setId(456);

$this->publicKeyTokenProvider
->expects($this->once())
->method('getTokenByUser')
->with('theUser')
->willReturn([$t1, $t2]);
$this->publicKeyTokenProvider
->expects($this->exactly(2))
->method('invalidateTokenById')
->withConsecutive(
['theUser', 123],
['theUser', 456],
);
$this->manager->invalidateTokensOfUser('theUser', null);
}

public function testInvalidateTokensOfUserClientNameGiven() {
$t1 = new PublicKeyToken();
$t2 = new PublicKeyToken();
$t3 = new PublicKeyToken();
$t1->setId(123);
$t1->setName('Firefox session');
$t2->setId(456);
$t2->setName('My Client Name');
$t3->setId(789);
$t3->setName('mobile client');

$this->publicKeyTokenProvider
->expects($this->once())
->method('getTokenByUser')
->with('theUser')
->willReturn([$t1, $t2, $t3]);
$this->publicKeyTokenProvider
->expects($this->once())
->method('invalidateTokenById')
->with('theUser', 456);
$this->manager->invalidateTokensOfUser('theUser', 'My Client Name');
}
}