add migration for encryption keys in wrong location #35107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
PVince81,
blizzz and
skjnldsv
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** | ||
| * @param Folder $folder | ||
| * @return \Generator<File> |
Check notice
Code scanning / Psalm
MoreSpecificReturnType
PVince81
approved these changes
Nov 14, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 code looks fine
see a few comments + proposed additions
nice usage of "yield from" and I liked seeing comments and justifications
| return 1; | ||
| } | ||
|
|
||
| \OC_Util::setupFS($user->getUID()); |
Member
There was a problem hiding this comment.
I guess you're not using the setup manager to easy backporting ?
blizzz
reviewed
Nov 14, 2022
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encryption-key-migrate
branch
from
5de2b74 to
dd4ebbd
Compare
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
This was referenced Nov 29, 2022
8 tasks
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes encryption keys for system wide external storages that were put in the wrong location before #32690
To test:
occ encryption:fix-key-location <userid>