Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Nov 15, 2022

This fixes the styling of vue-select elements as we will soon use the https://github.com/sagalbot/vue-select library in place of the https://github.com/shentao/vue-multiselect library

@Pytal Pytal added bug 3. to review Waiting for reviews labels Nov 15, 2022
@Pytal Pytal added this to the Nextcloud 26 milestone Nov 15, 2022
@Pytal Pytal self-assigned this Nov 15, 2022
@Pytal
Copy link
Member Author

Pytal commented Nov 15, 2022

/backport to stable25

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only adding :not([class^=vs__]) filter, right ?

For context, vue-select uses vs_ prefix for its classes.

Looks good :)

@Pytal
Copy link
Member Author

Pytal commented Nov 15, 2022

This is only adding :not([class^=vs__]) filter, right ?

For context, vue-select uses vs_ prefix for its classes.

Looks good :)

Yes :) added a comment https://github.com/nextcloud/server/blob/fix/vue-select-styles/core/css/inputs.scss#L32

Pytal added a commit to nextcloud-libraries/nextcloud-vue that referenced this pull request Nov 16, 2022
Pytal added a commit to nextcloud-libraries/nextcloud-vue that referenced this pull request Nov 16, 2022
Pytal added a commit to nextcloud-libraries/nextcloud-vue that referenced this pull request Nov 18, 2022
@Pytal Pytal requested a review from CarlSchwan November 23, 2022 00:34
@Pytal Pytal force-pushed the fix/vue-select-styles branch 2 times, most recently from 4d7da2f to 8784aa2 Compare November 25, 2022 00:40
@Pytal
Copy link
Member Author

Pytal commented Nov 25, 2022

Rebased

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming there is no better way

- Disable style override on NcActionButton with `:not(.action-button)`
  due to increased specificity over scoped Vue styles when only
  `:not([class^="vs__"])` is added

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the fix/vue-select-styles branch from 8784aa2 to d3d5034 Compare December 6, 2022 00:20
@Pytal
Copy link
Member Author

Pytal commented Dec 6, 2022

Also disable style override on NcActionButton with :not(.action-button) due to increased specificity over scoped Vue styles when only :not([class^="vs__"]) is added to fix nextcloud-libraries/nextcloud-vue#3542 with next automated styling update from server in https://github.com/nextcloud/nextcloud-vue

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2022
@Pytal Pytal merged commit 714a5dc into master Dec 6, 2022
@Pytal Pytal deleted the fix/vue-select-styles branch December 6, 2022 16:30
@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2022

Unfortunately, this selector is too strong, it override the default scoping most vue apps do

image

We need to revert and find a different selector without brackets
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants