-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
restoring clearCachedConfig() #35177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maxence Lange <[email protected]>
|
/backport to stable25 |
|
What exactly would be the use case there? If it is used in any app it probably should become a method on the public interface. |
Now the use cases:
(ie. this is used to avoid duplicate index by fulltextsearch) If the app can refresh the cache of |
Sounds more like a case for https://github.com/nextcloud/server/blob/fcae6a68c347e2913cc29f45648be37789f09c29/lib/public/Lock/ILockingProvider.php
While I know that is common behavior and used to also heavily make use of that, we might want to avoid this in the future due to the fact that all entries of oc_appconfig are loaded on every request. Maybe we could rather come up with a way to have a spearate config table for such things where entries are only queried from the DB when necessary - or introduce two types of values in oc_appconfig. Ones that are always loaded and others that apps need to request individually. Would be good to see what @PVince81 thinks about that. |
|
I'm not fully against getting this one back in, just that I think it might make sense to be careful how oc_appconfig is being (ab)used ;) |
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as discussed before with @ArtificialOwl
|
Failure unrelated |
restoring clearCachedConfig() that was removed in 25.0.0 with #32261
It can be useful in some use-case when config is edited by a parallel process