Skip to content

feat(occ): New command to delete previews #35189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charleypaulus wants to merge 14 commits into from
Closed

feat(occ): New command to delete previews #35189

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ee9c8e9
Added Delete class
charleypaulus Nov 14, 2022
7624f13
Registered delete previews command
charleypaulus Nov 14, 2022
1001c59
Corrected spaces to tabs
charleypaulus Nov 16, 2022
741236f
Corrected returned type (Github code scanning / Psalm issue)
charleypaulus Nov 17, 2022
58f444f
Handled batch deletion
charleypaulus Dec 1, 2022
82ec7f8
Fixed php-cs
charleypaulus Dec 1, 2022
77a358e
Ran composer install --no-dev
charleypaulus Dec 3, 2022
9f4b52c
Renamed old-only option to remnant-only
charleypaulus Dec 21, 2022
e76e86c
Caught negative batch size
charleypaulus Dec 21, 2022
d1419d9
Corrected condition on mimtype
charleypaulus Dec 21, 2022
9a5cddb
List available mimetypes when user inputs a non-existing one
charleypaulus Dec 21, 2022
7a70b59
Added getMimetypes in interface
charleypaulus Dec 21, 2022
5c1bf53
Added @since tag
charleypaulus Dec 22, 2022
a20461e
autoloaderchecker.sh after rebase
charleypaulus Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Corrected returned type (Github code scanning / Psalm issue) 
Signed-off-by: Charley Paulus <[email protected]>

Signed-off-by: charleypaulus <[email protected]>
  • Loading branch information
@charleypaulus
charleypaulus committed Nov 3, 2023
commit 741236f5d2db2d13d81e83687ee27aac7f8c819a
10 changes: 6 additions & 4 deletions core/Command/Preview/Delete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Output\OutputInterface;
use EmptyIterator;

class Delete extends Command {
protected IDBConnection $connection;
Expand Down Expand Up @@ -96,7 +97,7 @@ private function deletePreviews(OutputInterface $output, bool $oldOnly, string $
$output->writeln('Deleting previews of absent original file (fileid:' . $previewFileId . ')', OutputInterface::VERBOSITY_VERBOSE);
} else {
$output->writeln('Deleting previews of original file ' . substr($filePath, 7) . ' (fileid:' . $previewFileId . ')', OutputInterface::VERBOSITY_VERBOSE);
}
}

$previewFoldersToDeleteCount++;

Expand Down Expand Up @@ -129,11 +130,12 @@ private function getPreviewsToDelete(OutputInterface $output, bool $oldOnly, str
$data = $cursor->fetch();

Check notice

Code scanning / Psalm

PossiblyInvalidMethodCall

Cannot call method on possible int variable $cursor
$cursor->closeCursor();

Check notice

Code scanning / Psalm

PossiblyInvalidMethodCall

Cannot call method on possible int variable $cursor

$output->writeln('Preview folder: ' . $data['path'], OutputInterface::VERBOSITY_VERBOSE);

if ($data === null) {
return [];
$output->writeln('No preview folder found.');
return new EmptyIterator();
}

$output->writeln('Preview folder: ' . $data['path'], OutputInterface::VERBOSITY_VERBOSE);

// Get previews to delete
// Initialize Query Builder
Expand Down