Skip to content

Help pages: set window title for sidebar sections #35309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Nov 22, 2022
Merged

Help pages: set window title for sidebar sections #35309

ChristophWurst merged 1 commit into from
Nov 22, 2022

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 21, 2022

Fixes #33856

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 21, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 21, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 21, 2022

/backport to stable25

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 21, 2022
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Nov 21, 2022
@Pytal
Copy link
Member

Pytal commented Nov 21, 2022

PHP Parse error: syntax error, unexpected ')', expecting variable (T_VARIABLE) in ./apps/settings/lib/Controller/HelpController.php on line 63

Probably the trailing comma on line 62

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/fix-33856-Help_pages_Window_title_must_change_when_switching_sidebar_sections branch from 81fbe9a to 3559334 Compare November 22, 2022 08:32
@ChristophWurst ChristophWurst merged commit cad2e4d into master Nov 22, 2022
@ChristophWurst ChristophWurst deleted the fix/fix-33856-Help_pages_Window_title_must_change_when_switching_sidebar_sections branch November 22, 2022 13:12
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

[BITV] Help pages - Window title must change when switching sidebar sections

5 participants

@JuliaKirschenheuter @ChristophWurst @Pytal @juliusknorr