Skip to content

[stable25] Prevents the selection of encrypted folders when clicking on the "Select all" checkbox #35340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 7 commits into from
Nov 23, 2022
Merged

[stable25] Prevents the selection of encrypted folders when clicking on the "Select all" checkbox #35340

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfa0dab
Filelist:-Deselecting all files checkboxes within cells of encrypted …
TSI-kavitasonawane Nov 15, 2022
a96877a
Add comments for prevents the selection of encrypted folders
TSI-kavitasonawane Nov 15, 2022
eb756d8
Deactivates the possiblility to checkmark or click on the encrypted f…
TSI-kavitasonawane Nov 16, 2022
1b2441b
Prevents the selection of encrypted folder on scroll page
TSI-kavitasonawane Nov 17, 2022
a448205
Prevents the selection of encrypted folder on next page load
TSI-kavitasonawane Nov 18, 2022
895d068
Prevent selection of encrypted folders
TSI-kavitasonawane Nov 21, 2022
f9a2410
CSS compiled files for deactivates the possiblility to checkmark or c…
TSI-kavitasonawane Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Filelist:-Deselecting all files checkboxes within cells of encrypted … 
…folder

Signed-off-by: [email protected] <[email protected]>
  • Loading branch information
@TSI-kavitasonawane @backportbot-nextcloud
TSI-kavitasonawane authored and backportbot-nextcloud[bot] committed Nov 22, 2022
commit cfa0dab8f190fe1dc6f560dd2125c6164c93bfe3
3 changes: 2 additions & 1 deletion apps/files/js/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,7 @@
// Select only visible checkboxes to filter out unmatched file in search
this.$fileList.find('td.selection > .selectCheckBox:visible').prop('checked', checked)
.closest('tr').toggleClass('selected', checked);
this.$fileList.find('tr[data-e2eencrypted="true"]').find('td.selection > .selectCheckBox:visible').prop('checked', false).closest('tr').toggleClass('selected', false);

if (checked) {
for (var i = 0; i < this.files.length; i++) {
Expand All @@ -984,7 +985,7 @@
var fileData = this.files[i];
var fileRow = this.$fileList.find('tr[data-id=' + fileData.id + ']');
// do not select already selected ones
if (!fileRow.hasClass('hidden') && _.isUndefined(this._selectedFiles[fileData.id])) {
if (!fileRow.hasClass('hidden') && _.isUndefined(this._selectedFiles[fileData.id]) && (!fileData.isEncrypted)) {
this._selectedFiles[fileData.id] = fileData;
this._selectionSummary.add(fileData);
}
Expand Down