Skip to content

[stable25] Fix UX of renaming token #35390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Nov 24, 2022
Merged

[stable25] Fix UX of renaming token #35390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix UX of renaming token 
Now this get's instant applied and escaping will reset to the previous
state

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan @backportbot-nextcloud
CarlSchwan authored and backportbot-nextcloud[bot] committed Nov 24, 2022
commit ba9eb1308de716c7fdfa531a49131b468ca699f9
5 changes: 4 additions & 1 deletion apps/settings/src/components/AuthToken.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
v-model="newName"
type="text"
@keyup.enter="rename"
@blur="cancelRename"
@change="rename"
@keyup.esc="cancelRename">
<span v-else>{{ iconName.name }}</span>
<span v-if="wiping" class="wiping-warning">({{ t('settings', 'Marked for remote wipe') }})</span>
Expand Down Expand Up @@ -173,6 +173,7 @@ export default {
showMore: this.token.canScope || this.token.canDelete,
renaming: false,
newName: '',
oldName: '',
actionOpen: false,
}
},
Expand Down Expand Up @@ -232,6 +233,7 @@ export default {
// Close action (popover menu)
this.actionOpen = false

this.oldName = this.token.name
this.newName = this.token.name
this.renaming = true
this.$nextTick(() => {
Expand All @@ -240,6 +242,7 @@ export default {
},
cancelRename() {
this.renaming = false
this.$emit('rename', this.token, this.oldName)
},
revoke() {
this.actionOpen = false
Expand Down
Loading