Skip to content

Cleanup comments code #35424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 3 commits into from
Jun 20, 2023
Merged

Cleanup comments code #35424

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9725d00
Cleanup comments code
CarlSchwan Nov 25, 2022
77355a8
Improve typing in ICommentsManager
CarlSchwan Nov 28, 2022
7aa97dc
Throw if creation date is read before inserting into database
come-nc Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve typing in ICommentsManager 
Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan @come-nc
CarlSchwan authored and come-nc committed Jun 20, 2023
commit 77355a8a79898a03d4f45e853e3d99c9a633509b
6 changes: 2 additions & 4 deletions lib/public/Comments/ICommentsManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
*
* This class manages the access to comments
*
* @psalm-type CommentNode = array{comment: IComment, replies: list<CommentNode>}
* @psalm-type CommentTree = list<CommentNode>
*
* @since 9.0.0
*/
interface ICommentsManager {
Expand All @@ -64,11 +61,12 @@ interface ICommentsManager {
public function get($id);

/**
* returns the comment specified by the id and all it's child comments
* Returns the comment specified by the id and all it's child comments
*
* @param string $id
* @param int $limit max number of entries to return, 0 returns all
* @param int $offset the start entry
* @return array{comment: IComment, replies: list<array{comment: IComment, replies: array<empty, empty>}>}
* @since 9.0.0
*
* The return array looks like this
Expand Down