Skip to content

Fix SQL comparison with int array during external storage deletion #35502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
Nov 30, 2022
Merged

Fix SQL comparison with int array during external storage deletion #35502

CarlSchwan merged 1 commit into from
Nov 30, 2022

Conversation

@AndyXheli
Copy link
Contributor

@AndyXheli AndyXheli commented Nov 29, 2022 •
edited by ChristophWurst
Loading

Comparing to an array doesn't work. The query should use IN instead.

Fix #32007 (comment)

  • Resolves: #

Summary

TODO

  • ...

Checklist

Fix Executing a query: SQLSTATE[42000]
e69c7c4 
Signed-off-by: Andy Xheli <[email protected]>

Fix #32007 (comment)

Signed-off-by: Andy Xheli <[email protected]>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Nov 29, 2022
@ChristophWurst ChristophWurst changed the title Fix Executing a query: SQLSTATE[42000] Fix SQL comparison with int array during external storage deletion Nov 29, 2022
@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Nov 29, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 29, 2022

/backport to stable25

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 29, 2022

/backport to stable24

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 29, 2022

/backport to stable23

@szaimen szaimen requested review from a team, CarlSchwan and juliusknorr and removed request for a team November 29, 2022 19:07
juliusknorr
juliusknorr approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@CarlSchwan CarlSchwan merged commit 2b73c04 into nextcloud:master Nov 30, 2022
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2022
Merged
@AndyXheli AndyXheli deleted the patch-1 branch November 30, 2022 13:11
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 30, 2022

/backport to stable24

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 30, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: external storage

Projects

None yet

Milestone

Nextcloud 26

5 participants

@AndyXheli @ChristophWurst @juliusknorr @CarlSchwan @skjnldsv