Skip to content

Remove obsolete GD function overwrites #35560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 6 commits into from
Dec 4, 2022
Merged

Remove obsolete GD function overwrites #35560

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40166dd
Remove obsolete GD function overwrites
J0WI Jul 31, 2021
53994f6
Fix redundant condition
J0WI Sep 2, 2022
1dd3afe
Add type hints
J0WI Jul 31, 2021
110ea0d
Allow empty mimeType
J0WI Sep 2, 2022
f71b95e
Cleanup test exclusions
J0WI Sep 2, 2022
a4d0700
Fix test image default quality
J0WI Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix redundant condition 
Signed-off-by: J0WI <[email protected]>
  • Loading branch information
@J0WI
J0WI committed Dec 4, 2022
commit 53994f600d16ca976d95c701b7710a891b389ce4
2 changes: 1 addition & 1 deletion lib/private/legacy/OC_Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ private function _output($filePath = null, $mimeType = null) {
if (!$isWritable) {
$this->logger->error(__METHOD__ . '(): Directory \'' . dirname($filePath) . '\' is not writable.', ['app' => 'core']);
return false;
} elseif ($isWritable && file_exists($filePath) && !is_writable($filePath)) {
} elseif (file_exists($filePath) && !is_writable($filePath)) {
$this->logger->error(__METHOD__ . '(): File \'' . $filePath . '\' is not writable.', ['app' => 'core']);
return false;
}
Expand Down