-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Bump bootstrap from 4.6.1 to 5.2.3 #35567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26b422e to
0ad486a
Compare
|
These bootstrap v4 => v5 migration hints will help: https://getbootstrap.com/docs/5.2/migration/ |
|
/compile amend / |
0ad486a to
3939349
Compare
|
@dependabot recreate |
3939349 to
1285687
Compare
|
/compile amend / |
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.1 to 5.2.3. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.6.1...v5.2.3) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
1285687 to
10666fc
Compare
|
Is Bootstrap actually still used anywhere? All compiled JavaScript is identical, as far as I can see, only the asset version parameter has been updated. Probably only made available for apps, and then probably it makes sense to deprecate the global Bootstrap, like jQuery, to be shipped by apps themselves, when the Nextcloud core frameworks are not sufficient/wanted? |
Seems like we got rid of it yep! |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps bootstrap from 4.6.1 to 5.2.3.
Release notes
Sourced from bootstrap's releases.
... (truncated)
Commits
cb02143Dist3958947Bump version to 5.2.37e3074cfix tooltip/popper disposal inconsistencies (#37235)127a816fix(carousel): RTLtranslate()direction77c456dImport root inbootstrap-utilities(#37377)b722369Fix deprecation warning with sass 1.56.0 (#37425)961d5ffRelease v5.2.2 (#37236)9edfed8Don't redefine$border-colorintable-variantmixin (#37239)d49d8ceEnsure Tab keyboard functionality after #37146 (#37200)0a5f6e0Use\<h1>for allmodal-titleexamples/uses (#37210)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)