Skip to content

[stable25] Add fallback routines for empty secret cases #35605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 5 commits into from
Dec 5, 2022
Merged

[stable25] Add fallback routines for empty secret cases #35605

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4735ea
Add fallback routines for empty secret cases
juliusknorr Mar 9, 2022
3ebf7b8
Rotate token after fallback
juliusknorr Mar 10, 2022
0f7260d
Fix decryption fallback after adding a secret
juliusknorr Mar 10, 2022
1d33d37
Fix unit tests
CarlSchwan Mar 10, 2022
7416f44
Mark method as deprecated
CarlSchwan Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rotate token after fallback 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
(cherry picked from commit 553cb49)
  • Loading branch information
@juliusknorr @PVince81
juliusknorr authored and PVince81 committed Dec 5, 2022
commit 3ebf7b818be06f61893b2443bb50f2c556525f2c
10 changes: 8 additions & 2 deletions lib/private/Authentication/Token/PublicKeyTokenProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,14 @@ public function getToken(string $tokenId): IToken {
$token = $this->mapper->getToken($this->hashToken($tokenId));
$this->cache[$token->getToken()] = $token;
} catch (DoesNotExistException $ex) {
$this->cache[$tokenHash] = $ex;
throw new InvalidTokenException("Token does not exist: " . $ex->getMessage(), 0, $ex);
try {
$token = $this->mapper->getToken($this->hashTokenWithEmptySecret($tokenId));
$this->cache[$token->getToken()] = $token;
$this->rotate($token, $tokenId, $tokenId);
} catch (DoesNotExistException $ex2) {
$this->cache[$tokenHash] = $ex2;
Copy link
Contributor

@come-nc come-nc Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->cache[$tokenHash] = $ex2;
$this->cache[$tokenHash] = $ex;

Copy link
Member

@PVince81 PVince81 Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-critical, ignoring for now for the approaching release

can be addressed afterwards

throw new InvalidTokenException("Token does not exist: " . $ex->getMessage(), 0, $ex);
}
}
}

Expand Down