Skip to content

Automatically build sass and sass:icons after build #35622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Dec 7, 2022
Merged

Automatically build sass and sass:icons after build #35622

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3d9af7
Automatically build sass and sass:icons after build
skjnldsv Dec 6, 2022
b981b23
Update compile to not run sass twice
skjnldsv Dec 6, 2022
de3c5f2
Update node check to not run sass twice
skjnldsv Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update node check to not run sass twice 
They are now included in the `postbuild` npm step


Signed-off-by: John Molakvoæ <[email protected]>
  • Loading branch information
@skjnldsv
skjnldsv authored Dec 6, 2022
commit de3c5f2b1c7180b7aad771bbf50d02082c480d14
6 changes: 0 additions & 6 deletions .github/workflows/node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ jobs:
npm ci
npm run build --if-present

- name: Build css
run: npm run sass

- name: Build icons css
run: npm run sass:icons

- name: Check webpack build changes
run: |
bash -c "[[ ! \"`git status --porcelain `\" ]] || (echo 'Please recompile and commit the assets, see the section \"Show changes on failure\" for details' && exit 1)"
Expand Down