Skip to content

Conversation

@phil-davis
Copy link
Contributor

Signed-off-by: Phil Davis [email protected]

@mention-bot
Copy link

@phil-davis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @ChristophWurst to be potential reviewers.

@phil-davis
Copy link
Contributor Author

Re-submit of #3559 now with signed commit
Issue #3558

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Feb 21, 2017
@ChristophWurst ChristophWurst added this to the Nextcloud 12.0 milestone Feb 21, 2017
@codecov-io
Copy link

Codecov Report

Merging #3566 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3566      +/-   ##
============================================
+ Coverage     54.28%   54.28%   +<.01%     
  Complexity    21061    21061              
============================================
  Files          1310     1310              
  Lines         80354    80354              
  Branches       1250     1250              
============================================
+ Hits          43621    43624       +3     
+ Misses        36733    36730       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 92.77% <ø> (+0.16%) 120% <ø> (ø)
apps/files_external/lib/Lib/Storage/SMB.php 47.22% <ø> (+0.39%) 112% <ø> (ø)
lib/private/Files/Cache/Propagator.php 96.2% <ø> (+1.26%) 16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d754227...cbb7355. Read the comment docs.

@LukasReschke LukasReschke merged commit 54a5fe2 into master Feb 22, 2017
@LukasReschke LukasReschke deleted the setUpScenario1 branch February 22, 2017 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants