Skip to content

Allow target="_blank" in apps navigation items #35667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Jan 5, 2023
Merged

Allow target="_blank" in apps navigation items #35667

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c5273
Allow target="_blank" in app navigation items
tcitworld Dec 8, 2022
5bcc277
Recompile
nickvergessen Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow target="_blank" in app navigation items 
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79

Signed-off-by: Thomas Citharel <[email protected]>
  • Loading branch information
@tcitworld @nickvergessen
tcitworld authored and nickvergessen committed Jan 5, 2023
commit 56c5273206316125f0311566f895ece85c792930
4 changes: 3 additions & 1 deletion core/src/components/AppMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
:class="{ 'has-unread': app.unread > 0 }"
:aria-label="appLabel(app)"
:title="app.name"
:aria-current="app.active ? 'page' : false">
:aria-current="app.active ? 'page' : false"
:target="app.target ? '_blank' : undefined"
:rel="app.target ? 'noopener noreferrer' : undefined">
<img :src="app.icon" alt="">
<div class="app-menu-entry--label">
{{ app.name }}
Expand Down