[stable22] Use getLengthExpression to measure field length instead of like #35758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
PVince81,
blizzz,
come-nc and
nickvergessen
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
mejo-
force-pushed
the
backport/31696/stable22
branch
from
30db3e0 to
1578120
Compare
Member
|
I resolved the conflicts and backported the missing code parts manually. |
danxuliu
approved these changes
Dec 14, 2022
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Conflict resolution looks good 👍 (I can not judge the code, though)
come-nc
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #31696