Skip to content

[stable25] Change app menu focused items behavior that neighbor elements (text and border) have no overlapping #35771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Dec 23, 2022
Merged

[stable25] Change app menu focused items behavior that neighbor elements (text and border) have no overlapping #35771

JuliaKirschenheuter merged 1 commit into from
Dec 23, 2022

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Dec 14, 2022 •
edited by JuliaKirschenheuter
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #35501

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.3 milestone Dec 14, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 14, 2022

@JuliaKirschenheuter please make sure the diff is actually complete. I see fewer changes here than in the original PR.

Afterwards also cherry-pick the changes of #35545 onto this PR's branch.

@ChristophWurst ChristophWurst marked this pull request as draft December 14, 2022 15:02
@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Dec 14, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 16, 2022
@JuliaKirschenheuter JuliaKirschenheuter removed the 1. to develop Accepted and waiting to be taken care of label Dec 16, 2022
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review December 16, 2022 14:06
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 21, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 21, 2022

#35771 (comment) done?

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Dec 21, 2022
Closed
1 task
@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 21, 2022

/build fixup /

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 21, 2022

/compile fixup /

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 21, 2022

Untracked files:
(use "git add ..." to include in what will be committed)
dist/icons.css

@PVince81
Copy link
Member

PVince81 commented Dec 22, 2022

Untracked files:
(use "git add ..." to include in what will be committed)
dist/icons.css

I tried this locally without any git apps in "apps":
make dev-setup && make build-js-production && npm run sass && npm run sass:icons && git status

and there are no changes to commit, so icons.css is in the correct state (for both @JuliaKirschenheuter and I)
also rebased on top of origin/stable25

and yet the node test complains ?

@PVince81
Copy link
Member

PVince81 commented Dec 22, 2022

okay, looks like a gitignore quirk: the changeset on Github says that "icons.css" got removed, but recompiling locally and git status doesn't offer to re-add it.

I've now been able to explicitly readd it with git add dist/icons.css

@JuliaKirschenheuter be careful when discarding changes in "dist", never use delete operations and always "git checkout origin/stable25 dist/" instead

@JuliaKirschenheuter @PVince81
Change focused items behavior that neighbor elements (text and border…
055f421 
…) have no overlapping.

Add native tooltips to items.

Signed-off-by: julia.kirschenheuter <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@PVince81 PVince81 force-pushed the backport/35501/stable25 branch from 2c87151 to 055f421 Compare December 22, 2022 14:31
@JuliaKirschenheuter JuliaKirschenheuter added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 22, 2022
@JuliaKirschenheuter JuliaKirschenheuter merged commit dbc2ad9 into stable25 Dec 23, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the backport/35501/stable25 branch December 23, 2022 09:01
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility feature: accessibility

Projects

None yet

Milestone

Nextcloud 25.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @PVince81 @JuliaKirschenheuter