Skip to content

[stable25] Fix case sensitivity of email when saving settings #35803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 2 commits into from
Dec 19, 2022
Merged

[stable25] Fix case sensitivity of email when saving settings #35803

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b813d05
Fix case sensitivity of email when saving settings
CarlSchwan Oct 17, 2022
bf4f0d3
Add unit test for case insensitive email saving
PVince81 Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix case sensitivity of email when saving settings 
Otherwise we detect a email change all the time and since email are
immutable in ldap this prevent updating other fields.

Related: #33813

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan @backportbot-nextcloud
CarlSchwan authored and backportbot-nextcloud[bot] committed Dec 16, 2022
commit b813d05272c243d702025070ad039a5c9932bdef
2 changes: 1 addition & 1 deletion apps/settings/lib/Controller/UsersController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ protected function saveUserSettings(IAccount $userAccount): void {

$oldEmailAddress = $userAccount->getUser()->getSystemEMailAddress();
$oldEmailAddress = strtolower((string)$oldEmailAddress);
if ($oldEmailAddress !== $userAccount->getProperty(IAccountManager::PROPERTY_EMAIL)->getValue()) {
if ($oldEmailAddress !== strtolower($userAccount->getProperty(IAccountManager::PROPERTY_EMAIL)->getValue())) {
// this is the only permission a backend provides and is also used
// for the permission of setting a email address
if (!$userAccount->getUser()->canChangeDisplayName()) {
Expand Down