Skip to content

[stable23] Fix case sensitivity of email when saving settings #35805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
backportbot-nextcloud wants to merge 2 commits into from
Closed

[stable23] Fix case sensitivity of email when saving settings #35805

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9738419
Fix case sensitivity of email when saving settings
CarlSchwan Oct 17, 2022
f9a269b
Add unit test for case insensitive email saving
PVince81 Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add unit test for case insensitive email saving 
Signed-off-by: Vincent Petry <[email protected]>
  • Loading branch information
@PVince81 @backportbot-nextcloud
PVince81 authored and backportbot-nextcloud[bot] committed Dec 16, 2022
commit f9a269b25a685bbb3e69f20df416615cc8b0bb54
10 changes: 9 additions & 1 deletion apps/settings/tests/Controller/UsersControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ public function testSaveUserSettings($data,
$user->method('getSystemEMailAddress')->willReturn($oldEmailAddress);
$user->method('canChangeDisplayName')->willReturn(true);

if ($data[IAccountManager::PROPERTY_EMAIL]['value'] === $oldEmailAddress ||
if (strtolower($data[IAccountManager::PROPERTY_EMAIL]['value']) === strtolower($oldEmailAddress) ||
($oldEmailAddress === null && $data[IAccountManager::PROPERTY_EMAIL]['value'] === '')) {
$user->expects($this->never())->method('setSystemEMailAddress');
} else {
Expand Down Expand Up @@ -720,6 +720,14 @@ public function dataTestSaveUserSettings() {
'[email protected]',
null
],
[
[
IAccountManager::PROPERTY_EMAIL => ['value' => '[email protected]'],
IAccountManager::PROPERTY_DISPLAYNAME => ['value' => 'john doe'],
],
'[email protected]',
null
],

];
}
Expand Down