fix: remove other shares from ui when deleted #35836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the share entry in question when unsharing a folder from within the `others with access` section of a file within that folder. Using the code from the ShareList view here as well. Just copying the code here as this is a bugfix that will need to be backported. Signed-off-by: Max <[email protected]>
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
blizzz
requested review from
a team,
PVince81,
skjnldsv and
szaimen
and removed request for
a team
mejo-
approved these changes
Dec 20, 2022
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Code looks good to me. Didn't test, but I guess you did so 😉
artonge
approved these changes
Dec 20, 2022
juliusknorr
approved these changes
Dec 21, 2022
Member
|
Failures are unrelated. |
This was referenced Dec 21, 2022
Contributor
Author
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the share entry in question
when unsharing a folder
from within the
others with accesssectionof a file within that folder.
Using the code from the ShareList view here as well. Just copying the code here as this is a bugfix
that will need to be backported.
Checklist
Documentation (manuals or wiki) has been updated oris not required