default the preview_max_memory to a half of the max php memory

[szaimen]

Close #31284

[kesselb]

The value depends on your machine. I fear we are going to introduce the next "wonky" test ;)
Could you try to set the memory limit for this test to a fixed value?

ini_set('memory_limit', '256M');

Best would be to mock the MemoryInfo class but that's a bit tricky here.

[szaimen]

Could you try to set the memory limit for this test to a fixed value?

ini_set('memory_limit', '256M');

Good idea, thanks! :)

[kesselb]

server/lib/private/legacy/OC_Image.php

Line 597 in 5848a36

$this->logger->debug('Image size of ' . $width . 'x' . $height . ' would exceed allowed memory limit of ' . $memory_limit);

A higher log level could also help.

Auto-calculating preview_max_memory is a bit too much magic for me.
I prefer to improve our documentation instead of yet another runtime check for a static value.

[szaimen]

Auto-calculating preview_max_memory is a bit too much magic for me.

All right. Then lets increase the default to 256 and also increase the log entry to info which should fix the issue as well imho.

[kesselb]

All right. Then lets increase the default to 256 and also increase the log entry to info which should fix the issue as well

Your choice ;) I just shared my concerns.

The issue with info is that most people use warning as default log level.

[szaimen]

Superseded by #35856