Skip to content

[stable24] Quota value as float for 32-bit systems #35940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 5 commits into from
Jan 3, 2023
Merged

[stable24] Quota value as float for 32-bit systems #35940

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8239752
Remove quota value type for 32-bit systems
PVince81 Dec 12, 2022
5421510
Make it clear that file sizes may be float on 32bits
come-nc Dec 19, 2022
39cb354
Adapt types of subclasses
come-nc Dec 19, 2022
602cc72
Silence a warning from psalm with explanation
come-nc Dec 19, 2022
6def133
Remove null from quota type
come-nc Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Silence a warning from psalm with explanation 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Jan 2, 2023
commit 602cc7260c2d3c83ae8f6502fa0cb27819cb7e78
1 change: 1 addition & 0 deletions lib/private/Files/Storage/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,7 @@ public function moveFromStorage(IStorage $sourceStorage, $sourceInternalPath, $t
}

public function writeStream(string $path, $stream, int $size = null): int {
/** @var int|false $result We consider here that returned size will never be a float because we write less than 4GB */
$result = $this->file_put_contents($path, $stream);
if (is_resource($stream)) {
fclose($stream);
Expand Down