Skip to content

Conversation

@nickvergessen
Copy link
Member

Backport #35957

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jan 3, 2023
@nickvergessen nickvergessen added this to the Nextcloud 25.0.3 milestone Jan 3, 2023
@nickvergessen nickvergessen self-assigned this Jan 3, 2023
Comment on lines +18 to +31
submodules: true

- name: Set up php
uses: shivammathur/setup-php@v2
with:
php-version: '8.0'
extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
coverage: none
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Composer install
run: composer i

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with the use of docker://vimeo/psalm-github-actions:4.9.3 below which already has php and psalm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but in #34997 we are merging this file with the other one anyway)

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

This comment was marked as resolved.

@nickvergessen nickvergessen force-pushed the backport/359577stable25 branch from 30bfe80 to 4fb6f30 Compare January 4, 2023 15:10
@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member

skjnldsv commented Jan 4, 2023

Indent is wrong: FIXED
Cancelled drone as it's irrelevant here

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2023
@skjnldsv skjnldsv merged commit 348f3ab into stable25 Jan 4, 2023
@skjnldsv skjnldsv deleted the backport/359577stable25 branch January 4, 2023 17:09
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants