Skip to content

Conversation

@icewind1991
Copy link
Member

Follow up for #36047 with tests

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 9, 2023
@icewind1991 icewind1991 added this to the Nextcloud 26 milestone Jan 9, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and come-nc and removed request for a team January 9, 2023 14:33

// hack to overwrite the cache factory, we can't use the proper "overwriteService" since the mount provider is created before this test is called
$mountProvider = \OCP\Server::get(MountProvider::class);
$reflectionClass = new \ReflectionClass($mountProvider);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might be able to use self::invokePrivate() also to set values

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 10cca65 into master Jan 10, 2023
@PVince81 PVince81 deleted the share-mount-check-cache-key-test branch January 10, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants