Skip to content

Fix inability to re-enter share password after invalid input #36074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jan 11, 2023
Merged

Fix inability to re-enter share password after invalid input #36074

PVince81 merged 1 commit into from
Jan 11, 2023

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jan 10, 2023

Screenshot
Before image
After image

@Pytal Pytal added this to the Nextcloud 26 milestone Jan 10, 2023
@Pytal Pytal self-assigned this Jan 10, 2023
@Pytal
Copy link
Member Author

Pytal commented Jan 10, 2023

/backport to stable25

@Pytal
Copy link
Member Author

Pytal commented Jan 10, 2023

/backport to stable24

@Pytal
Copy link
Member Author

Pytal commented Jan 10, 2023

/backport to stable23

PVince81
PVince81 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit afa2953 into master Jan 11, 2023
@PVince81 PVince81 deleted the fix/share-password branch January 11, 2023 08:26
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 11, 2023 •
edited by Pytal
Loading

The backport to stable25 failed. Please do this backport manually.

#36106

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 11, 2023 •
edited by Pytal
Loading

The backport to stable24 failed. Please do this backport manually.

#36107

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 11, 2023 •
edited by Pytal
Loading

The backport to stable23 failed. Please do this backport manually.

23 is EOL https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

This was referenced Jan 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Pytal Pytal

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@Pytal @PVince81 @skjnldsv