Catch Exceptions when loading storage data of users #36115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having the whole userlist crashing because a user external storage fails to load. With this change only the problematic user storage/quota information will be empty. Signed-off-by: Côme Chilliet <[email protected]>
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
Contributor
Author
|
/backport to stable23 |
come-nc
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
4 tasks
blizzz
reviewed
Jan 12, 2023
| self::USER_FIELD_QUOTA => $quota !== false ? $quota : 'none', | ||
| 'used' => 0 | ||
| ]; | ||
| } catch (\Exception $e) { |
Contributor
Author
There was a problem hiding this comment.
On purpose, I do not want exceptions there to crash the whole user list because one user cannot have its quota shown.
Signed-off-by: Côme Chilliet <[email protected]>
blizzz
approved these changes
Jan 12, 2023
artonge
approved these changes
Jan 16, 2023
come-nc
added
4. to release
This was referenced Jan 16, 2023
Member
|
/backport to stable23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet [email protected]
Summary
This avoids having the whole userlist crashing because a user external
storage fails to load. With this change only the problematic user
storage/quota information will be empty.
Checklist