Add success message to personal settings clipboard button #36250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julia.kirschenheuter <[email protected]>
2 tasks
Contributor
Author
|
/backport to stable25 |
PVince81
reviewed
Jan 19, 2023
| } | ||
| await navigator.clipboard.writeText(this.cloudId) | ||
| this.isCopied = true | ||
| showSuccess(t('federatedfilesharing', 'Copied!')) |
Member
There was a problem hiding this comment.
is the text "Copied!" enough or should it be a longer message with context ?
Member
There was a problem hiding this comment.
We use it like this everywhere
ChristophWurst
changed the title
ChristophWurst
approved these changes
Jan 23, 2023
ChristophWurst
added
4. to release
nickvergessen
deleted the
fix/add-success-message-to-personal-settings-button
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After:
Summary
Add success message to personal settings button
Checklist