-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
non-static app_dir #36257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-static app_dir #36257
Conversation
|
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fix the issue in my testing. Thanks a lot for fixing this @ArtificialOwl! :)
However I am not sure if this has some negative performance implications...
|
I would not say it is the final fix, for it may have performance impact (not 100% sure, but otherwise the static var would not make sense). Alternatively it could be an override parameter, for instance, that would avoid the runtime cache in update scenarios. |
please check last commit; it should ignores cached data only during install/upgrade |
fc7eac7 to
e52f931
Compare
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as well in my testing (but cannot judge the code). Thanks Maxence! :)
Signed-off-by: Maxence Lange <[email protected]>
e52f931 to
4cac49c
Compare
|
CI failure unrelated |
Fix nextcloud/related_resources#170
Close #18673
Should fix nextcloud/all-in-one#1787 (comment)
There is an edge use case where custom apps folder seems ignored during server upgrade.
When upgrading the server:
While it seems a minor issue because it only require to initiate a second upgrading process, it locks AIO Nextcloud because the upgrade cannot be initiated from the webclient (but only by running
./occ upgrade)This PR will trigger the upgrading process of the apps installed in custom apps during the upgrading process of the server.