Fix WHERE condition when selecting user's availability for the status… #36260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… automation Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
requested review from
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
4 tasks
vitormattos
approved these changes
Jan 23, 2023
|
The backport to stable24 failed. Please do this backport manually. |
Member
Author
|
New in 25, so okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… automation
Summary
Over some time now I noticed that my user status was not toggling correctly with my working schedule.
Since I had quite a "complex" time schedule I assumed the math/checking of IN or OUT is not working.
But after trying to extract my data from our instance to replay it locally, I found the root-cause and it's so much simpler.
Since this is not the first time we have a where-whereOr/whereAnd-where situation, I wonder if we should add some safety net by logging an error when
whereis being used on a query builder while the current where is not empty. But it reduces reusability of QueryBuilder objects (a pattern I dislike anyway 😅)Checklist