Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 20, 2023

Signed-off-by: Côme Chilliet [email protected]

Summary

Result of the run of composer run cs:fix
Follow up of #34997

Checklist

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc added this to the Nextcloud 26 milestone Jan 20, 2023
@come-nc come-nc self-assigned this Jan 20, 2023
@come-nc come-nc added 3. to review Waiting for reviews technical debt labels Jan 20, 2023
@come-nc come-nc requested a review from skjnldsv January 20, 2023 10:49
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backporters hate this trick

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@come-nc
Copy link
Contributor Author

come-nc commented Jan 20, 2023

  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:36
153	    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
154	    And I visit the admin settings page                                                                                       # SettingsMenuContext::iVisitTheAdminSettingsPage()
155	    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
156	    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
157	    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
158	    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
159	    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
160	    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
161	      Failed asserting that true is false.
162	    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

I’m pretty sure the drone failure is not related to the changes in the PR.

@come-nc come-nc merged commit 3f231d6 into master Jan 20, 2023
@come-nc come-nc deleted the fix/fix-codestyle branch January 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants