Skip to content

Bugfix/32630/get access list use correct array key #36305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ASerbinski wants to merge 2 commits into from
Closed

Bugfix/32630/get access list use correct array key #36305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4c173
ShareByMailProvider: getAccessList: Use correct array key
ASerbinski May 27, 2022
9a567fe
ShareByMailProviderTest: testGetAccessList: use correct array key
ASerbinski Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ShareByMailProviderTest: testGetAccessList: use correct array key 
Change array key from public to mail.

Signed-off-by: Adam Serbinski <[email protected]>
  • Loading branch information
@ASerbinski
ASerbinski committed Jan 24, 2023
commit 9a567fe5a81d5d827bf1fb08944fc8bc900b0692
32 changes: 16 additions & 16 deletions apps/sharebymail/tests/ShareByMailProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,11 +1086,11 @@ public function testGetAccessList() {
$folder = $rootFolder->getUserFolder($u1->getUID())->newFolder('foo');

$accessList = $provider->getAccessList([$folder], true);
$this->assertArrayHasKey('public', $accessList);
$this->assertFalse($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertFalse($accessList['mail']);
$accessList = $provider->getAccessList([$folder], false);
$this->assertArrayHasKey('public', $accessList);
$this->assertFalse($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertFalse($accessList['mail']);

$share1 = $this->shareManager->newShare();
$share1->setSharedWith('[email protected]')
Expand All @@ -1109,29 +1109,29 @@ public function testGetAccessList() {
$share2 = $provider->create($share2);

$accessList = $provider->getAccessList([$folder], true);
$this->assertArrayHasKey('public', $accessList);
$this->assertTrue($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertTrue($accessList['mail']);
$accessList = $provider->getAccessList([$folder], false);
$this->assertArrayHasKey('public', $accessList);
$this->assertTrue($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertTrue($accessList['mail']);

$provider->delete($share2);

$accessList = $provider->getAccessList([$folder], true);
$this->assertArrayHasKey('public', $accessList);
$this->assertTrue($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertTrue($accessList['mail']);
$accessList = $provider->getAccessList([$folder], false);
$this->assertArrayHasKey('public', $accessList);
$this->assertTrue($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertTrue($accessList['mail']);

$provider->delete($share1);

$accessList = $provider->getAccessList([$folder], true);
$this->assertArrayHasKey('public', $accessList);
$this->assertFalse($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertFalse($accessList['mail']);
$accessList = $provider->getAccessList([$folder], false);
$this->assertArrayHasKey('public', $accessList);
$this->assertFalse($accessList['public']);
$this->assertArrayHasKey('mail', $accessList);
$this->assertFalse($accessList['mail']);

$u1->delete();
$u2->delete();
Expand Down