Skip to content

Fix default value for files_no_background_scan #36333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
Jan 24, 2023
Merged

Fix default value for files_no_background_scan #36333

kesselb merged 1 commit into from
Jan 24, 2023

Conversation

@max-nextcloud
Copy link
Contributor

@max-nextcloud max-nextcloud commented Jan 24, 2023 •
edited
Loading

The value is read in

server/apps/files/lib/BackgroundJob/ScanFiles.php

Line 105 in b888c61

if ($this->config->getSystemValueBool('files_no_background_scan', false)) {
and the default value is false.

Summary

The documented default value for files_no_background_scan was wrong.

Checklist

@max-nextcloud
Copy link
Contributor Author

max-nextcloud commented Jan 24, 2023

/backport to stable25

@max-nextcloud
Copy link
Contributor Author

max-nextcloud commented Jan 24, 2023

/backport to stable24

@max-nextcloud
Copy link
Contributor Author

max-nextcloud commented Jan 24, 2023

I'm not sure how best to update the documentation based on this. I can change the value there directly or try and rebuild it from the config.sample.php.

szaimen
szaimen approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen added this to the Nextcloud 26 milestone Jan 24, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Jan 24, 2023
kesselb
kesselb approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kesselb kesselb merged commit 75d7203 into master Jan 24, 2023
@kesselb kesselb deleted the docs/fix-files_no_background_scan-default branch January 24, 2023 20:23
@kesselb
Copy link
Contributor

kesselb commented Jan 24, 2023

The documentation should be updated automatically ;)

This was referenced Jan 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@szaimen szaimen szaimen approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@max-nextcloud @kesselb @szaimen