Skip to content

Adapt native tooltip for new structure of NcAvatar #36358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuliaKirschenheuter merged 1 commit into from
Feb 28, 2023
Merged

Adapt native tooltip for new structure of NcAvatar #36358

JuliaKirschenheuter merged 1 commit into from
Feb 28, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 25, 2023 •
edited
Loading

Resolves: #36357

Summary

Remove title and aria-label attributes from NcAvatar components in files_sharing.

Before After
Screenshot from 2023-01-25 15-26-14 Screenshot from 2023-01-25 15-22-51
Screenshot from 2023-01-25 15-25-58 Screenshot from 2023-01-25 15-23-03

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 25, 2023
@nickvergessen
Copy link
Member

nickvergessen commented Jan 25, 2023

Conflicting files
dist/files_sharing-files_sharing_tab.js
dist/files_sharing-files_sharing_tab.js.map

nickvergessen
nickvergessen reviewed Jan 25, 2023
View reviewed changes
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft January 26, 2023 08:39
@JuliaKirschenheuter JuliaKirschenheuter added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 26, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jan 26, 2023
Merged
2 tasks
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from c49f8da to e74f43c Compare February 24, 2023 15:23
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review February 24, 2023 15:23
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 24, 2023 •
edited
Loading

can't do /backport to stable25 yet because stable25 has "@nextcloud/vue": "^7.5.0" https://github.com/nextcloud/server/blob/stable25/package.json#L49. Needed version: https://github.com/nextcloud/nextcloud-vue/releases/tag/v7.6.0

@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 24, 2023
@Pytal
Copy link
Member

Pytal commented Feb 24, 2023 •
edited
Loading

can't do /backport to stable25 yet because stable25 has "@nextcloud/vue": "^7.5.0" stable25/package.json#L49. Needed version: nextcloud/nextcloud-vue@v7.6.0 (release)

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from e74f43c to 9be573a Compare February 27, 2023 14:06
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch from 9be573a to 76999d1 Compare February 27, 2023 14:41
@JuliaKirschenheuter JuliaKirschenheuter merged commit 28e35ba into master Feb 28, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36357-Adapt_tooltips_on_NcAvatar_for_files_sharing branch February 28, 2023 10:19
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 28, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 28, 2023
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BITV]: Adapt tooltips on NcAvatar for files_sharing

5 participants

@JuliaKirschenheuter @nickvergessen @Pytal @artonge