Skip to content

feat(app-framework): Add UseSession attribute to replace annotation #36363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Jan 27, 2023
Merged

feat(app-framework): Add UseSession attribute to replace annotation #36363

ChristophWurst merged 1 commit into from
Jan 27, 2023

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 25, 2023 •
edited
Loading

  • Resolves: the urge to do something fancy

Summary

https://help.nextcloud.com/t/how-should-we-use-php8-attributes/104278

TODO

  • Add new attribute
  • Adjust session middleware
  • Migrate core controllers

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Jan 25, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 25, 2023
zak39
zak39 reviewed Jan 25, 2023
View reviewed changes
@ChristophWurst ChristophWurst mentioned this pull request Jan 26, 2023
Merged
rullzer
rullzer approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy pancy

miaulalala
miaulalala approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clueless

@ChristophWurst ChristophWurst force-pushed the feat/app-framework/usesession-attribute branch from af46e6a to 7f39c72 Compare January 26, 2023 12:47
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 26, 2023
@juliusknorr
Copy link
Member

juliusknorr commented Jan 27, 2023

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh

@ChristophWurst ChristophWurst force-pushed the feat/app-framework/usesession-attribute branch from 7f39c72 to 20e00cd Compare January 27, 2023 08:40
@ChristophWurst ChristophWurst merged commit 7269766 into master Jan 27, 2023
@ChristophWurst ChristophWurst deleted the feat/app-framework/usesession-attribute branch January 27, 2023 15:59
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jan 29, 2023
@nickvergessen
Copy link
Member

nickvergessen commented Jan 29, 2023

Please document in #34692

@ChristophWurst ChristophWurst mentioned this pull request Jan 30, 2023
Closed
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Jan 30, 2023
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Feb 9, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zak39 zak39 zak39 left review comments

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@miaulalala miaulalala miaulalala approved these changes

@vitormattos vitormattos Awaiting requested review from vitormattos

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

7 participants

@ChristophWurst @juliusknorr @nickvergessen @rullzer @miaulalala @zak39