Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jan 26, 2023

Summary

Port the clear status after select to NcSelect

Checklist

@Pytal
Copy link
Member Author

Pytal commented Jan 27, 2023

The width property
https://github.com/sagalbot/vue-select/blob/857753655adbebae612518aab072ed7f4a8deaa0/src/directives/appendToBody.js#L4-L9
is ~10px less than it should be when opening the dropdown for the first time

Further investigations to be done

@Pytal Pytal force-pushed the enh/a11y-clear-status-select branch from 545dedc to 4c26fa7 Compare February 2, 2023 01:29
@Pytal
Copy link
Member Author

Pytal commented Feb 2, 2023

The initial width issue on first open can be reproduced on Chrome on Windows and Linux

Screenshot
Chrome (Windows) image
Chrome (Linux) image
Expected width

The width is normal when opening subsequent times

Screenshot
Opening subsequent times image

And also reproduces on Firefox on Windows but not Linux

Screenshot
Firefox (Windows) image
Firefox (Linux) image

Further investigations needed

Edit: Fixed in nextcloud-libraries/vue-select#14 and the reason why Firefox (Linux) works is because it determined that overlay scrollbars should be used automatically as described in https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter

@Pytal Pytal force-pushed the enh/a11y-clear-status-select branch from 4c26fa7 to 1ee94df Compare February 4, 2023 00:47
@Pytal
Copy link
Member Author

Pytal commented Feb 4, 2023

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the enh/a11y-clear-status-select branch from 1ee94df to 225332b Compare February 4, 2023 00:55
@artonge
Copy link
Contributor

artonge commented Feb 8, 2023

Does the bug in #36372 (comment) reproduce for you @artonge?

I can reproduce in Chrome on Linux and not on Firefox.

Maybe it is because the computation happens when the scale is less than 1 ?
It looks like we are animating the modal:
https://github.com/nextcloud/nextcloud-vue/blob/c1a15b3f6c5cec758cd0461b154821ef07fd5013/src/components/NcModal/NcModal.vue#L980-L983

@artonge
Copy link
Contributor

artonge commented Feb 8, 2023

It also happens if I open the modal, resize the window, which resize NcSelect. So probably nothing to do with the animation.

@Pytal
Copy link
Member Author

Pytal commented Feb 11, 2023

Fixed upstream in nextcloud-libraries/vue-select#14

@Pytal
Copy link
Member Author

Pytal commented Feb 24, 2023

Superseded by #36843

@Pytal Pytal closed this Feb 24, 2023
@Pytal Pytal deleted the enh/a11y-clear-status-select branch February 24, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants