Skip to content

perf(bundles): Improve nextcloud-vue import to only load components once #36383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliusknorr wants to merge 8 commits into from
Closed

perf(bundles): Improve nextcloud-vue import to only load components once #36383

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9857943
perf(bundles): Improve import to only load components once
juliusknorr Jan 26, 2023
48921d2
fix: Revert NcHighlight import for now
juliusknorr Feb 1, 2023
d99da9f
fix: Revert some non exported ones
juliusknorr Feb 6, 2023
54c3537
chore: Fix build warnings
juliusknorr Feb 13, 2023
b76817f
chore: remove unused @nextcloud/vue-dashboard
juliusknorr Feb 13, 2023
2165d1b
tests: Fix jest transforms
juliusknorr Feb 13, 2023
7023d12
chore: Bump @nextcloud/dialogs and nextcloud-vue-collections
juliusknorr Feb 13, 2023
bf30aee
chore(webpack): Move to node-polyfill-webpack-plugin
juliusknorr Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Revert NcHighlight import for now 
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
@juliusknorr
juliusknorr committed Feb 14, 2023
commit 48921d2316f5689d5ce9a2de79f689dc9908bdfd
3 changes: 2 additions & 1 deletion core/src/views/UnifiedSearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ import debounce from 'debounce'
import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { showError } from '@nextcloud/dialogs'

import { NcActionButton, NcActions, NcEmptyContent, NcHeaderMenu, NcHighlight } from '@nextcloud/vue'
import { NcActionButton, NcActions, NcEmptyContent, NcHeaderMenu } from '@nextcloud/vue'
import NcHighlight from '@nextcloud/vue/dist/Components/NcHighlight'

import Magnify from 'vue-material-design-icons/Magnify.vue'

Expand Down