Skip to content

[stable25] Fix focus not returning to search icon #36398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jan 27, 2023
Merged

[stable25] Fix focus not returning to search icon #36398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix focus not returning to search icon 
- Remove programmatic focusing already handled by focus-trap

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@Pytal @nextcloud-command
Pytal authored and nextcloud-command committed Jan 26, 2023
commit ad12f75798aa5df5c11c95110f422396c2449a6a
2 changes: 0 additions & 2 deletions core/src/views/UnifiedSearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@ export default {
if (event.ctrlKey && event.key === 'f' && !this.open) {
event.preventDefault()
this.open = true
this.focusInput()
}

// https://www.w3.org/WAI/GL/wiki/Using_ARIA_menus
Expand All @@ -374,7 +373,6 @@ export default {

methods: {
async onOpen() {
this.focusInput()
// Update types list in the background
this.types = await getTypes()
},
Expand Down
Loading